feat: watch command execute on successful build#151
feat: watch command execute on successful build#151jacoobes merged 6 commits intosern-handler:mainfrom
Conversation
|
@jacoobes i also request a review from you :) |
|
|
||
| console.log(`[watch] running command: ${cmd}`); | ||
|
|
||
| currentProcess = execa(cmd, { stdio: 'inherit', shell: true }); |
There was a problem hiding this comment.
is it possible to timeout this?
EvolutionX-10
left a comment
EvolutionX-10
left a comment
There was a problem hiding this comment.
Everything else Looks good to me, confirm testing with @jacoobes
|
it works well for me |
|
Will check tonight! One thing I was thinking about is how often does it
refresh? We want it to be reasonable with api publisher limits
…On Fri, Jan 31, 2025 at 1:31 PM SrIzan10 ***@***.***> wrote:
it works well for me
—
Reply to this email directly, view it on GitHub
<#151 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASJS6OZSUWZNJQBJ674ZWVD2NPFQLAVCNFSM6AAAAABWDYFDDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRYGE3DENRTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
i will test this week. stuff got pushed |
|
API proposal: theres this proposal adds |
|
i think it already does that. if there's a watch command run that, else the start command |
ahhh i see okay |
|
lets push a dev release, how does that sound? @SrIzan10 @EvolutionX-10 that way we can let the community test it. |
|
before that i need to implement debouncing on build calls to avoid extra calls |
|
note: esbuild local npm links do not work with watch command |
3 participants
absolute cinema